Swift: Make file checking in tests more strict#19344
Merged
jketema merged 1 commit intogithub:mainfrom Apr 22, 2025
Merged
Conversation
With Swift 6.1 the extractor will start to extract files outside of the test directory. These files and their elements we do not want to see in our tests.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (8)
- swift/ql/test/TestUtils.qll: Language not supported
- swift/ql/test/library-tests/elements/decl/enumdecl/enumdecl.ql: Language not supported
- swift/ql/test/library-tests/elements/decl/function/function.ql: Language not supported
- swift/ql/test/library-tests/elements/type/nominaltype/nominaltype.ql: Language not supported
- swift/ql/test/library-tests/elements/type/nominaltype/nominaltypedecl.ql: Language not supported
- swift/ql/test/library-tests/elements/type/numerictype/numerictype.ql: Language not supported
- swift/ql/test/library-tests/elements/type/pointertypes/pointertypes.ql: Language not supported
- swift/ql/test/query-tests/Diagnostics/Info.ql: Language not supported
jketema
added a commit
to jketema/codeql
that referenced
this pull request
Apr 22, 2025
With Swift 6.1 the extractor will start to extract files outside of the test directory. These files and their elements we do not want to see in our tests. Test forgotten in github#19344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Swift 6.1 the extractor will start to extract files outside of the test directory. These files and their elements we do not want to see in our tests.
Targeting
mainwith this PR to ensure we do not break something by accident in the upgrade.