Skip to content

Fix Go extractor silent failures and improve error recovery #20676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Go extractor silent failures and improve error recovery #20676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9440984
Fix Go extractor silent failures and improve error recovery
allsmog Oct 22, 2025
3e54fad
Merge branch 'main' into fix-go-extractor-oom-errors
allsmog Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions go/extractor/extractor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,12 +692,18 @@ func (extraction *Extraction) extractPackage(pkg *packages.Package) {
extraction.WaitGroup.Add(1)
extraction.GoroutineSem.acquire(1)
go func(astFile *ast.File) {
defer func() {
if r := recover(); r != nil {
log.Printf("Panic during file extraction in package %s: %v", pkg.PkgPath, r)
}
extraction.GoroutineSem.release(1)
extraction.WaitGroup.Done()
}()

err := extraction.extractFile(astFile, pkg)
if err != nil {
log.Fatal(err)
log.Printf("Error extracting file in package %s: %v", pkg.PkgPath, err)
}
extraction.GoroutineSem.release(1)
extraction.WaitGroup.Done()
}(astFile)
}
}
Expand Down