Skip to content

Conversation

Copy link

Copilot AI commented Jan 16, 2026

The proxy-cached experiment flag has been rolled out and is now always enabled. This PR removes the conditional logic as the proxy now defaults to cached mode.

Changes:

  • Removed experiments['proxy-cached'] check from Updater.runUpdater()
  • Removed cachedMode parameter from ProxyBuilder constructor
  • Removed PROXY_CACHE environment variable (no longer needed as proxy defaults to cached mode)
  • Updated integration tests to reflect simplified API

Before:

const cachedMode = this.details.experiments?.hasOwnProperty('proxy-cached') === true
const proxyBuilder = new ProxyBuilder(this.docker, this.proxyImage, cachedMode)

After:

const proxyBuilder = new ProxyBuilder(this.docker, this.proxyImage)
// Proxy now defaults to cached mode, no env var needed
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove the proxy-cached feature flag from dependabot-action</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

  • Fixes github/dependabot-updates#12002

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove the proxy-cached feature flag from dependabot-action Remove proxy-cached feature flag Jan 16, 2026
Copilot AI requested a review from pavera January 16, 2026 22:57
@pavera
Copy link
Contributor

pavera commented Jan 16, 2026

@copilot also do not set the PROXY_CACHE env var when running the proxy container. The proxy is also being modified to default to cached mode so this env var is no longer used

Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
Copy link
Author

Copilot AI commented Jan 16, 2026

@copilot also do not set the PROXY_CACHE env var when running the proxy container. The proxy is also being modified to default to cached mode so this env var is no longer used

Done. Removed the PROXY_CACHE environment variable in commit 6d4cf2a.

@pavera pavera marked this pull request as ready for review January 16, 2026 23:06
@pavera pavera requested a review from a team as a code owner January 16, 2026 23:06
Copilot AI review requested due to automatic review settings January 16, 2026 23:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the proxy-cached feature flag that has been rolled out and is now always enabled, simplifying the codebase by removing conditional logic around proxy caching.

Changes:

  • Removed the cachedMode parameter from the ProxyBuilder constructor
  • Removed the PROXY_CACHE environment variable from proxy container configuration
  • Removed the experiments['proxy-cached'] check from the Updater.runUpdater() method

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/updater.ts Removed the cachedMode variable and conditional logic checking for the proxy-cached experiment flag, simplified ProxyBuilder instantiation
src/proxy.ts Removed cachedMode parameter from constructor and removed PROXY_CACHE environment variable from container configuration
dist/main/index.js Updated compiled JavaScript to reflect source code changes
tests/updater-builder-integration.test.ts Simplified test to remove cachedMode parameter, but introduced a bug with incorrect argument order
tests/proxy-integration.test.ts Simplified test to remove cachedMode parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pavera pavera marked this pull request as draft January 16, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants