update Fetch Licenses workflow to only create a PR if the generated files changed #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles changed Also adding the ability to force tests to run. They get stuck sometimes in PRs. This avoids the need to do a minor change like adding whitespace to a file just to get the tests to run.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the Fetch Licenses workflow to only open a pull request when generated files have actually changed and adds a manual trigger to rerun tests.
- Enable manual rerun of the test workflow via
workflow_dispatch - Add source JSON and generated-file change checks in the fetch-licenses workflow to guard PR creation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/test.yaml | Added workflow_dispatch trigger to allow manual test reruns |
| .github/workflows/fetch-licenses.yaml | Introduced checks for source JSON and generated-file changes and updated the PR creation condition |
Comments suppressed due to low confidence (1)
.github/workflows/fetch-licenses.yaml:44
- [nitpick] Consider capitalizing "JSON" in the step name for consistency: use "Check for changes in SPDX JSON files".
- name: Check for changes in SPDX json files
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PRs are created when the SPDX json files change data that is not included in go-spdx generated files. This is unnecessary since it does not impact or improve the operation of go-spdx. It is simply noise.
This update adds an additional check after files are generated to determine if those files were changed. A PR will be created only if the generated files have changed.