Compare performance: Show names of query runs being compared #4170
+48
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgerf
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the performance comparison UI by displaying the names of query runs being compared and clarifying their relative positions (left vs right). The implementation refactors the data flow to pass complete query info objects instead of just log paths, enabling the extraction of query names for display.
- Refactored
showResultsto acceptCompletedLocalQueryInfoobjects instead of file paths - Added query run names to the comparison UI with a list showing which runs are being compared
- Updated the message interface to include both name and data for each query run
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| extensions/ql-vscode/src/extension.ts | Simplified to pass complete query info objects to the view instead of extracting log paths |
| extensions/ql-vscode/src/compare-performance/compare-performance-view.ts | Refactored to handle query info objects, extract names using label provider, and include names in messages |
| extensions/ql-vscode/src/common/interface-types.ts | Updated message interface to wrap performance data with query names |
| extensions/ql-vscode/src/view/compare-performance/ComparePerformance.tsx | Updated to access nested data structure and display query run names in the UI |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
extensions/ql-vscode/src/compare-performance/compare-performance-view.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/compare-performance/compare-performance-view.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/compare-performance/compare-performance-view.ts
Outdated
Show resolved
Hide resolved
extensions/ql-vscode/src/compare-performance/compare-performance-view.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a list of the query runs being compared, and their relative order. The UI for opening the comparison doesn't make it clear which is run will appear on the left or on the right.