-
Couldn't load subscription status.
- Fork 213
Bump jest version to 30.2.0 #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Jest dependencies from an alpha version (30.0.0-alpha.7) to a stable release (30.2.0), which is needed to unblock another pull request. The update moves away from pre-release versions to a production-ready version of Jest.
- Upgraded
@jest/environmentfrom v30.0.0-alpha.7 to v30.2.0 - Upgraded
@jest/environment-jsdom-abstractfrom v30.0.0-alpha.7 to v30.2.0
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Makes sense to me to do this upgrade and get back onto normal releases if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I think it would also make sense to update the version of the jest package itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updates the jest version, which should unblock #4174. (I'm not sure why dependabot hasn't suggested this update yet—possibly because we were on a weird alpha version of jest previously.)
Anyway, see #4174 (comment) for the details!
(ℹ️ Note: I don't plan to merge this until after the GH Universe code freeze is lifted 🧊)