-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Update walkthrough #4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update walkthrough #4842
Conversation
4353bf2 to
7b3cd9a
Compare
|
@copilot please review changes of this PR and add a CHANGELOG note linked to |
|
@sergeibbb I've opened a new pull request, #4845, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: sergeibbb <83944326+sergeibbb@users.noreply.github.com>
Co-authored-by: sergeibbb <83944326+sergeibbb@users.noreply.github.com>
|
One thing I concerned here about is that I could delete too much. The visualized result of these changes is in this comment in Jira: |
🤖 Augment PR SummarySummary: This PR refreshes the GitLens Welcome walkthrough to streamline onboarding and better highlight core features. Changes:
Technical Notes: Introduces an 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c032d39 to
2b0e9cc
Compare
axosoft-ramint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about sending through source for telemetry.
src/commands/walkthroughs.ts
Outdated
| name: 'open/composer', | ||
| command: command, | ||
| }); | ||
| executeCommand(command); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please send the walkthrough as a source here. All the composer telemetry needs it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
axosoft-ramint
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the context needed to do anything here besides a code scan for technical issues, but having found no other issues, LGTM
f4e4d27 to
d8046b3
Compare
Description
Solves #4846 (PLG-121)
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses