[image-builder-bob] update buildkit version#19383
Merged
Conversation
Contributor
Author
|
Related to #19382 ...which hit a limit due to lets encrypt rate limiting. Good luck, new branch! |
kylos101
commented
Feb 2, 2024
| # See License.AGPL.txt in the project root for license information. | ||
|
|
||
| FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.2-gitpod.1 | ||
| FROM eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0 |
Contributor
Author
There was a problem hiding this comment.
The image is already pushed to GCR
Contributor
Author
There was a problem hiding this comment.
docker run --rm -it eu.gcr.io/gitpod-core-dev/build/buildkit:v0.12.5-gitpod.0 --version
buildkitd github.com/moby/buildkit v0.12.5-4-gaf7854806 af7854806a5721a31ef1c22b18ea434882687711
Contributor
Author
There was a problem hiding this comment.
aledbf
approved these changes
Feb 2, 2024
Also, drive-by changes to fix linter issues for preview scripts
4922066 to
954dfb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to our latest buildkit fork, which is on v0.12.5.
Related Issue(s)
Fixes ENG-1639
How to test
Using this test repo: https://github.com/kylos101/gitpod-custom-image
gp validateand open the debug workspaceDocumentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold