Preliminary support for index format v3 #2081
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
requested changes
Nov 2, 2025
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for tackling this!
I think it would be useful to add a small test-index directly, one that is known to be V3. The Gitoxide repository definitely has them: https://github.com/GitoxideLabs/gitoxide/blob/ecd354119c3a8b150a06df7205ddf022a825d6cd/gix-index/tests/fixtures/loose_index/extended-flags.git-index
Thanks again.
| def test_index_version_v3(self, tmp_dir): | ||
| tmp_dir = Path(tmp_dir) | ||
| with cwd(tmp_dir): | ||
| subprocess.run(["git", "init", "-q"], check=True) |
Member
There was a problem hiding this comment.
Would it be possible to use the Git type instead? That way one would benefit from all the 'extras', especially around finding the right Git binary.
|
|
||
| repo = Repo(tmp_dir) | ||
|
|
||
| assert len(repo.index.entries) == 1 |
Member
There was a problem hiding this comment.
To test this, I think the index.version must be exposed and validated here.
I don't see at all why it would use index version 3 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1960