Fix build on Visual Studio 2022, add love track support #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much painstaking trials and tribulations (I have never used Visual Studio or done windows-targeted / C++ builds of this complexity before), I've figured out how to build this project and add features to it.
The vcpkg version referenced was quite outdated (2022) and pointed to dependency tarballs that don't exist anymore on the target servers. I updated the version of vcpkg to point to the latest one, and ported the patch for
outcometo the most recent stable version of that project: lc-guy/vcpkg@45422e0There were also issues when loading the project in Visual Studio 2022 related to mismatches between version 1.0.0 and 2.0.0 of foo_scrobble-deps which I fixed by fiddling with the GUI somehow.
I added support for a feature I've wanted for a while -- loving tracks. Seems to work fine. Only supports unconditionally loving a track -- no unloving since I don't need that and it would've been more complex to implement. I barely know any C++ and never worked on the foobar SDK, so Claude did most of the work for me. Feel free to merge it or rework it.
Fixes #8
compiled component available here: https://github.com/lc-guy/foo_scrobble/releases/tag/v1.6.0-love