Add dash types #91
Merged
Add dash types #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
requested changes
Nov 30, 2025
Collaborator
swsnr
left a comment
swsnr
left a comment
There was a problem hiding this comment.
Please add documentation comments where possible, and in particular annotate all top-level types with a @version doc tag to indicate the GNOME version they were checked against. See the other type definitions for examples.
leandromqrs
force-pushed
the
main
branch
2 times, most recently
from
e4a8e57 to
4236d14
Compare
Contributor
Author
|
Done! |
swsnr
approved these changes
Dec 2, 2025
swsnr
requested changes
Dec 2, 2025
Collaborator
swsnr
left a comment
swsnr
left a comment
There was a problem hiding this comment.
You'll also need to add the new file to the exports in package.json.
Contributor
Author
|
I forget about these part. Done! |
swsnr
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types for Dash. I use it for dock extension while extending the dash option. You can find in https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/ui/dash.js