Skip to content

Rework CDM mapper #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ludwiglierhammer merged 6 commits into from
Dec 15, 2025
Merged

Rework CDM mapper #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af12b11
split into several smaller functions
ludwiglierhammer Dec 12, 2025
d80be54
update cdm_mapper tests
ludwiglierhammer Dec 12, 2025
3e1df84
split _map_and_convert
ludwiglierhammer Dec 12, 2025
c737642
get_cdm_atts: return empty dict if cdm_subset is not in properties.cd…
ludwiglierhammer Dec 15, 2025
04499c8
more test
ludwiglierhammer Dec 15, 2025
0798a6e
update CHANGELOG
ludwiglierhammer Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ New features and enhancements

* new Pub47 testdata (test_data["test_pub47"]) (:pull:`327`)

Breaking changes
^^^^^^^^^^^^^^^^
* ``cdm_reader_mapper.cdm_mapper``: rename `map_and_covnert` to helepr function `_map_and_convert` (:pull:`343`)

Internal changes
^^^^^^^^^^^^^^^^
* implement map_model test for Pub47 data (:issue:`310`, :pull:`327`)
Expand All @@ -29,6 +33,7 @@ Internal changes
* ``cdm_reader_mapper.cdm_mapper``: update mapping functions for more readability (:pull:`324`)
* ``cdm_reader_mapper.cdm_mapper``: introdice some helper functions (:pull:`324`)
* add more unit tests (:issue:`311`, :pull:`324`)
* ``cdm_reader_mapper.cdm_mapper``: split `map_and_convert` into multiple helper functions (:issue:`333`, :pull:`343`)

Bug fixes
^^^^^^^^^
Expand Down
Loading
Loading