performance: use maps in conn.bind to avoid nested loops #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

pquerna wants to merge 2 commits into glebarez:master from pquerna:pq/bulk_insert_bind

pquerna commented Dec 18, 2024

When using INSERT ... VALUES() with a large number of rows, we found that we were spending a decent percentage of CPU time in the bind() function, specifically in the nested for loops inside bind -> we were looping over the args, and inside that looping over the entire arguments array.

pquerna added 2 commits

December 18, 2024 04:31


          conn.bind: use indexes by ordinal or name when finding args

da8a72f


          minimize allocations

e558987

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet