resolve PTR query (reverse lookup) to FQDN#22
Open
lalyos wants to merge 1 commit intogliderlabs:masterfrom
Open
resolve PTR query (reverse lookup) to FQDN#22lalyos wants to merge 1 commit intogliderlabs:masterfrom
lalyos wants to merge 1 commit intogliderlabs:masterfrom
Conversation
Contributor
Author
|
You can test this PR applied to resolvable as and than start a fqdn container: |
|
Only question I have is whether it's possible that the container domain name is empty, and then does the trailing Other than that, seems fine to me, although I admit I don't understand why this makes PTR work :). |
Contributor
Author
|
reverse lookups (PTR records) is already working, it just resoles to the short name. This PR is So right nowit works like this: The trailing dot is actually how PTR-s are working, so it doesnt break anything. |
|
This works great for me. Tested with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverse lookups shoud probably resolve to the hostname, where the domain is included.