Remove usage of session variable glpipdffont#19169
Closed
RomainLvr wants to merge 1 commit intoglpi-project:10.0/bugfixesfrom
Closed
Remove usage of session variable glpipdffont#19169RomainLvr wants to merge 1 commit intoglpi-project:10.0/bugfixesfrom
RomainLvr wants to merge 1 commit intoglpi-project:10.0/bugfixesfrom
Conversation
trasher
reviewed
Mar 10, 2025
| $font = 'helvetica'; | ||
| $font = 'dejavusans'; | ||
| $fontsize = 8; | ||
| if (isset($_SESSION['glpipdffont']) && $_SESSION['glpipdffont']) { |
Contributor
There was a problem hiding this comment.
I'm not sure we should remove that (no idea if it's used by plugins, but that may). At least, we probably should keep in bugfixes versions.
cedric-anne
requested changes
Mar 10, 2025
Member
cedric-anne
left a comment
cedric-anne
left a comment
There was a problem hiding this comment.
Users can customize their font. For some languages, the dejavusans may not provide all symbols.
IMHO, we should not remove the ability to customize the used font.
Contributor
|
This PR has been is closed and has been automatically locked. Please open a new issue with all requested information for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description