Skip to content

Conversation

@maartenbreddels
Copy link
Collaborator

@maartenbreddels maartenbreddels commented Nov 23, 2021

Start of implementation of spacetelescope/jdaviz#914

TODO:

  • bqplot Bar does not handle log y scale correctly
  • bqplot-image-gl does not support log scales
  • the scale_x and scale_y if figure need to be linked to for instance the MouseInteration

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (f8e24b8) 86.65% compared to head (3aa2f1a) 75.27%.

❗ Current head 3aa2f1a differs from pull request most recent head 794506f. Consider uploading reports for the commit 794506f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #273       +/-   ##
===========================================
- Coverage   86.65%   75.27%   -11.38%     
===========================================
  Files          89       82        -7     
  Lines        5154     4190      -964     
===========================================
- Hits         4466     3154     -1312     
- Misses        688     1036      +348     
Files Coverage Δ
glue_jupyter/bqplot/tests/test_bqplot.py 100.00% <100.00%> (ø)
glue_jupyter/view.py 94.50% <100.00%> (+0.12%) ⬆️
glue_jupyter/__init__.py 63.23% <12.50%> (-7.26%) ⬇️
glue_jupyter/bqplot/common/viewer.py 76.71% <65.78%> (-11.57%) ⬇️

... and 56 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maartenbreddels
Copy link
Collaborator Author

@dhomeier dhomeier added the enhancement New feature or request label Apr 12, 2022
@maartenbreddels maartenbreddels force-pushed the feat_log_plot branch 3 times, most recently from d587cda to 794506f Compare November 7, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants