Skip to content

Conversation

@astrofrog
Copy link
Member

The figure for test_contour_units looks better now, also there were hashes missing for two tests.

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.50%. Comparing base (f997e7d) to head (27febbf).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   85.07%   82.50%   -2.58%     
==========================================
  Files          91       91              
  Lines        5407     5441      +34     
==========================================
- Hits         4600     4489     -111     
- Misses        807      952     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhomeier dhomeier added bug Something isn't working testing bqplot-viewers labels Oct 2, 2025
@dhomeier
Copy link
Contributor

dhomeier commented Oct 2, 2025

Are those the two tests reenabled in #479?

@dhomeier dhomeier removed the bug Something isn't working label Oct 2, 2025
Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit confusingly some of the tests are passing in #479 with different hashes; here all are [x]passing, but test_visual_linestyle and test_visual_vector are still marked xfail.

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to remove the 2 xfails here already and merge, then #479 can rebase to bring in the additional checks to test_visual_linestyle.

@dhomeier
Copy link
Contributor

dhomeier commented Dec 3, 2025

I suggest to remove the 2 xfails here already and merge, then #479 can rebase to bring in the additional checks to test_visual_linestyle.

@astrofrog my commit to re-enable those tests ended up in https://github.com/glue-viz/glue-jupyter/tree/astrofrog-update-hashes as it seems I cannot directly push to this PR (permissions problem?); checks there resulted in a different image mismatch in test_visual_scatter2d_density[chromium], but I could not reproduce that failure on rerunning the visual tests (now with Astropy 7.2, just in case) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants