-
Notifications
You must be signed in to change notification settings - Fork 39
Update figure hashes #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update figure hashes #495
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
- Coverage 85.07% 82.50% -2.58%
==========================================
Files 91 91
Lines 5407 5441 +34
==========================================
- Hits 4600 4489 -111
- Misses 807 952 +145 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Are those the two tests reenabled in #479? |
dhomeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit confusingly some of the tests are passing in #479 with different hashes; here all are [x]passing, but test_visual_linestyle and test_visual_vector are still marked xfail.
dhomeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove the 2 xfails here already and merge, then #479 can rebase to bring in the additional checks to test_visual_linestyle.
@astrofrog my commit to re-enable those tests ended up in https://github.com/glue-viz/glue-jupyter/tree/astrofrog-update-hashes as it seems I cannot directly push to this PR (permissions problem?); checks there resulted in a different image mismatch in |
The figure for test_contour_units looks better now, also there were hashes missing for two tests.