Skip to content

Conversation

@brotherbard
Copy link

I separated the item spacing into horizontal and vertical to allow for better layout customization.

@brotherbard
Copy link
Author

I created separate properties because I don't think of the spacing as a size and didn't want to overload CGSize to mean something else. But if people prefer it as CGSize I'll change it.

Also, as I've been playing with the spacing I think I want to change it based on portrait or landscape. The margins as well. I'm currently abusing GMGridView:sizeForItemsInInterfaceOrientation: to change these settings but maybe there should be a separate delegate call for that. And I'm not sure if it should be the data source delegate so a new layout delegate? Any preferences? Or is that the correct place to change things.

@gmoledina
Copy link
Owner

I really don't think we should handle this level of detail for the spacing as it will get hard to manage. Later we might even need different spacing per orientation too, and it just gets too much.

I suggest the grid only handles the minimum and the when creating the cell, you can play with your own subviews and layers and add more spacing if required.

@dibsme
Copy link

dibsme commented Jan 2, 2013

Thanks. It works charm.

@morteza2128
Copy link

Thanks alOOOt
Horizontal and vertical item spacing were necessary !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants