SafeArea support (fix for iPhone X, iPhone 11, iPad Pro series devices)#23
Open
mark-dlc wants to merge 1 commit intogmunhoz:masterfrom
Open
SafeArea support (fix for iPhone X, iPhone 11, iPad Pro series devices)#23mark-dlc wants to merge 1 commit intogmunhoz:masterfrom
mark-dlc wants to merge 1 commit intogmunhoz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on the devices that have a notch or otherwise use a safearea, the library faces serious issues since buttons on the top (among of which the close button) are hidden behind the notch or in the safearea rendering them unusable (#21)
This pull request fixes this issue, by dynamically adding top padding to account for this. This pull request has been tested on devices with and without SafeArea in both landscape and portrait orientations.