Open
Conversation
gnuns
requested changes
Jul 21, 2020
Owner
gnuns
left a comment
gnuns
left a comment
There was a problem hiding this comment.
Hi, @07souravkunda! Thank you for this awesome contribution and sorry for taking so long to review!
Co-authored-by: gabriel nunes <981105+gnuns@users.noreply.github.com>
Co-authored-by: gabriel nunes <981105+gnuns@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
It resolves issue #55 .
In this commit I have set up the redis database for caching.
I am using etag header of the url to check whether saved response is modified.
@gnuns please review my code and suggest if these can be done in other efficient way.