Merged
Conversation
Collaborator
c2h5oh
commented
Jun 26, 2025
c2h5oh
commented
- Require Origin header to be set to consider a request to be a preflight request
- Allow empty Origin header - see note https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/CORS#origin
c2h5oh
force-pushed
the
origin_header_check
branch
from
5f89c00 to
2258c81
Compare
Contributor
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
Looks good.
CORS pre-flights require both Origin and Access-Control-Request-Method headers. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.