feat: allow to customize log message#74
Open
sad-fat-cat wants to merge 1 commit intogo-chi:masterfrom
Open
Conversation
| }, | ||
|
|
||
| LogFormat: func(r *http.Request, statusCode int, d time.Duration) string { | ||
| return fmt.Sprintf("%s %s => HTTP %v", r.Method, r.URL, statusCode) |
Contributor
There was a problem hiding this comment.
out of curiosity, what's the format you're thinking of for yourself?
Author
There was a problem hiding this comment.
Just constant string, like "request processed".
Because all info about request already stored in slog attrs, and variance part in message field sort of difficult to work with aggregations (for example, % of uniq clients were affected by a particular error in this operation).
I thought about just putting the template string in the params, but the function seems more flexible, in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New option
LogFormat, that lets you control the format of the log messages