Skip to content

feat: add SupportPackageIsVersion1 compile-time version sentinel#27

Merged
ankurs merged 2 commits intomainfrom
feat/support-package-version-sentinel
Mar 26, 2026
Merged

feat: add SupportPackageIsVersion1 compile-time version sentinel#27
ankurs merged 2 commits intomainfrom
feat/support-package-version-sentinel

Conversation

@ankurs
Copy link
Copy Markdown
Member

@ankurs ankurs commented Mar 26, 2026

Summary

  • Add SupportPackageIsVersion1 constant following the gRPC SupportPackageIsVersion pattern
  • Reference upstream package sentinels to enforce version compatibility at compile time
  • When a breaking change is made, export a new version and remove the old one to force coordinated updates

Test plan

  • go build ./... passes (with updated upstream dependencies)

Add version compatibility constant and reference upstream package
sentinels to enforce coordinated version updates at compile time.
Follows the gRPC SupportPackageIsVersion pattern.
Copilot AI review requested due to automatic review settings March 26, 2026 01:23
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

Warning

Rate limit exceeded

@ankurs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 44 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3193fb0a-f4a1-4f3d-a2d2-111cdafde876

📥 Commits

Reviewing files that changed from the base of the PR and between c33c2da and 1363aa5.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • databuilder.go
  • go.mod
  • plan.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/support-package-version-sentinel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds compile-time “version sentinel” constants to enforce coordinated dependency updates (similar to gRPC’s SupportPackageIsVersion pattern), and updates the tracing dependency accordingly.

Changes:

  • Export SupportPackageIsVersion1 from this module for downstream compile-time compatibility checks.
  • Add a compile-time reference to tracing.SupportPackageIsVersion1 to pin compatibility with the upstream tracing package.
  • Bump github.com/go-coldbrew/tracing to v0.1.0 (and update module sums / indirect deps).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
plan.go Adds upstream tracing version sentinel reference to enforce compile-time compatibility.
databuilder.go Exports SupportPackageIsVersion1 sentinel for downstream compatibility enforcement.
go.mod Updates tracing to v0.1.0 and adjusts indirect requirements.
go.sum Updates checksums for the tracing version bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ankurs ankurs merged commit e7f34e5 into main Mar 26, 2026
5 checks passed
@ankurs ankurs deleted the feat/support-package-version-sentinel branch March 26, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants