Skip to content

fix: escape $ in Makefile bench target#29

Merged
ankurs merged 1 commit intomainfrom
fix/makefile-bench-regex
Apr 2, 2026
Merged

fix: escape $ in Makefile bench target#29
ankurs merged 1 commit intomainfrom
fix/makefile-bench-regex

Conversation

@ankurs
Copy link
Copy Markdown
Member

@ankurs ankurs commented Apr 1, 2026

Summary

  • Use ^$$ instead of ^$ in Makefile bench target so Make passes a literal $ to the shell, giving go test -run the correct regex ^$ (match no test names).

Test plan

  • make bench runs benchmarks only, no unit tests

Use ^$$ so Make passes literal ^$ to the shell, ensuring
go test -run matches no test names (benchmarks only).
Copilot AI review requested due to automatic review settings April 1, 2026 13:56
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Warning

Rate limit exceeded

@ankurs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 23 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 23 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3719b039-ef04-4f2b-96ab-48343d23acde

📥 Commits

Reviewing files that changed from the base of the PR and between 0453fba and d2110ac.

📒 Files selected for processing (1)
  • Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/makefile-bench-regex

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the bench Makefile target so that make bench passes the correct -run regex to go test, ensuring benchmarks run without executing unit tests.

Changes:

  • Escape $ correctly in the bench target by changing -run=^$ to -run=^$$.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ankurs ankurs merged commit b8d8f57 into main Apr 2, 2026
8 checks passed
@ankurs ankurs deleted the fix/makefile-bench-regex branch April 2, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants