Remove unnecessary function parameter #35765
Open
+11
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
added
the
type/refactoring
github-actions
bot
added
modifies/api
delvh
reviewed
Oct 28, 2025
| return err | ||
| } | ||
|
|
||
| notify_service.MergePullRequest(baseGitRepo.Ctx, doer, pr) |
There was a problem hiding this comment.
Wait, doesn't this introduce a regression?
Didn't we explicitly change it to this specific context to have a deadline that is different from the request deadline?
With the previous approach, it is merged in the background.
With the new approach, it cannot take longer than the request…
There was a problem hiding this comment.
I think they are the same. Both are *services/context.Context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.