Return error if userObject is not found#37
Open
Danielss89 wants to merge 5 commits intogoalio:masterfrom
Open
Conversation
| $this->setSatisfied(false); | ||
|
|
||
| $e->setCode(AuthenticationResult::FAILURE) | ||
| ->setMessages(array('User not found.')); |
There was a problem hiding this comment.
Maybe this the message needs to be an class constant as wel??
Collaborator
Author
There was a problem hiding this comment.
It's not in constants in the other cases, so it's not in the scope of this ticket to move it :)
stijnhau
reviewed
Feb 25, 2017
| ), | ||
|
|
||
| 'factories' => array( | ||
| 'goaliorememberme_rememberme_service' => function ($sm) { |
There was a problem hiding this comment.
I think the factories should move to separate file so we dion't break the caching of this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it results in a fatal error.