Allow for a leaf to order regexps such that ones with patterns are ch…#74
Open
AlskiOnTheWeb wants to merge 3 commits intogocraft:masterfrom
Open
Allow for a leaf to order regexps such that ones with patterns are ch…#74AlskiOnTheWeb wants to merge 3 commits intogocraft:masterfrom
AlskiOnTheWeb wants to merge 3 commits intogocraft:masterfrom
Conversation
Author
|
I've added one more feature that we use. In the case that a path parameter uses a pattern that has a capturing group, that captured group will be returned as the path value when appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will fix the case where a node in the route tree has several entries. Ones with regexps are weighted to be checked first. The case it fixes are when there are routes like:
and
The current behavior is that the second case will never be checked because the first always matches. This pull will ensure that the "with json extension" will be checked first.