react-native 0.57.4 & gradle 4+ support

[patrickkempff]

• Added method to customise dependency versions (by defining rootProject.ext), same implementation consistent with other react-native libraries like react-native-fast-image & react-native-maps
• Fixed build issue on react-native 0.57.3
• Upgraded android support recyclerview to 26.0.3 v27.1.1
• Upgraded android buildtools to 26.0.3 v27.0.3
• Fixed compiler warnings compile vs implementation more info
• Removed unused NotAnimatedItemAnimator class
• Upgraded to gradle plugin v3.1.4
• Upgraded to gradle v4.4
• Fixed the basic tests
• Upgraded example app to react-native 0.57.4
• Switched to yarn instead of npm for example app
• Updated README.md to reflect new changes

[godness84]

Why removing prop-types as dependency? Different packages can have different versions of prop-types, can't they?

[patrickkempff]

I have added the prop-types as an peer dependency instead. As react-native is moving away from prop-types in favour of flow typings, I think we should investigate if we can ditch proptypes for flow/typescript typings.

[godness84]

I don't like prop-types too, but adding it as a peer dependency means that users of this lib must have prop-types as a direct dependency in their main package.json, and I don't like it. Would you mind to leave it as a direct dependency of this lib? Afterwards, I'll merge this PR immediately!

[patrickkempff]

@godness84 yeah of course! I will update it according to your feedback. 👍

[godness84]

@patrickkempff thank you for your great job! I added some suggestions, let me know what you think about

[patrickkempff]

@godness84 I am a bit busy at the moment but I will take a look somewhere this week. Thank you for the feedback!

[enahum]

@patrickkempff it would be awesome if you just apply the suggestions made by @godness84 so this can get merged, looking forward to it, I've included the PR in my fork.

On a different note, @godness84 would you take a PR that adds support to refresh the recycle list on both sides with a SwipeRefreshLayout ?

[patrickkempff]

Thank you @godness84, I have applied your suggestions.

[ariona]

when this will be merged?

[henrikra]

I came across this same problem when updating to RN 0.57.4. What if we make smaller PR which changes only this part:

Because all the other things are related to the example app. Only this one line change would make it work with RN 0.57.4. What do you guys think?

[patrickkempff]

I created this PR a couple of months ago, if there is anything I can do to get this merged let me know.

[henrikra]

@patrickkempff Can you make smaller PR out of this? You could do PR which only does the changes in RecyclerViewBackedScrollViewManager.java file. That is enough for this to work with React Native 0.57.4. This way the PR is way smaller and easier to merge. After that has been merged then you can do other PR which updates the example app :)

[a396901990]

waiting this PR~

[Nishchit14]

OMG, This would be merged. It's blocking to upgrade RN to 0.57.

Is this library being maintained?

[henrikra]

Because this library is NOT maintained I have forked this library and made only the minimal changes in order to keep it running.
You can install my forked version with npm i react-native-recyclerview-fixed.
The repo for the fork is there https://github.com/henrikra/react-native-recyclerview-list

You can see from my PRs to my fork that I have made this library to work up to React Native 0.58.6 https://github.com/henrikra/react-native-recyclerview-list/pulls?q=is%3Apr+is%3Aclosed 🎉

[nastarfan]

@henrikra Thanks for your repo, I manage to make it work on RN 0.59.10, debug version works perfectly.
However, I am facing an issue when trying to build release version of my app with command .\gradlew assembleRelease. I got the following error:

Note: there were 1 references to unknown classes.
      You should check your configuration for typos.
      (http://proguard.sourceforge.net/manual/troubleshooting.html#unknownclass)
Note: there were 875 unkept descriptor classes in kept class members.
      You should consider explicitly keeping the mentioned classes
      (using '-keep').
      (http://proguard.sourceforge.net/manual/troubleshooting.html#descriptorclass)
Note: there were 15 unresolved dynamic references to classes or interfaces.
      You should check if you need to specify additional program jars.
      (http://proguard.sourceforge.net/manual/troubleshooting.html#dynamicalclass)
Warning: there were 8 unresolved references to program class members.
         Your input classes appear to be inconsistent.
         You may need to recompile the code.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedprogramclassmember)
Warning: Exception while processing task java.io.IOException: Please correct the above warnings first.
Thread(Tasks limiter_1): destruction

> Task :app:transformClassesAndResourcesWithProguardForRelease FAILED

FAILURE: Build failed with an exception.

I have confirmed that the issue is caused by this library, I've tried to remove it and build with no issue. I don't know if I suppose to report an issue on here since it doesn't seem to be actively maintained currently.
I hope you guys can help me if you know how to resolve this issue