[3.x] Use if constexpr in Object::derives_from#108199
Merged
lawnjelly merged 1 commit intogodotengine:3.xfrom Jul 2, 2025
Merged
[3.x] Use if constexpr in Object::derives_from#108199lawnjelly merged 1 commit intogodotengine:3.xfrom
if constexpr in Object::derives_from#108199lawnjelly merged 1 commit intogodotengine:3.xfrom
Conversation
lawnjelly
approved these changes
Jul 2, 2025
Member
|
Thanks! |
Member
There's likely a whole lot of cases in templates, probably in need of a bulk PR which we can do soon. |
akien-mga
changed the title
if constexpr in Object::derives_fromif constexpr in Object::derives_from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
if constexpris supported, it should be used where appropriate.This one instance immediately came to mind.
This change should not change anything in the output binary if compilers are good, but guarantees that the
ifis compiled away. So it should be added.