[MSDF] Add font variation to control outline roundness.#109629
Open
bruvzg wants to merge 1 commit intogodotengine:masterfrom
Open
[MSDF] Add font variation to control outline roundness.#109629bruvzg wants to merge 1 commit intogodotengine:masterfrom
bruvzg wants to merge 1 commit intogodotengine:masterfrom
Conversation
bruvzg
force-pushed
the
msdf_opts
branch
4 times, most recently
from
0aa1507 to
0a0bcda
Compare
Calinou
reviewed
Aug 18, 2025
Member
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
However, while the PR's functionality works, I found a regression that also affects this PR while testing this: #109757
Some issues:
- The MSDF Rounded Outline property is visible even on non-MSDF fonts, unlike other MSDF properties:
Member
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #109437, adds
msdf_rounded_outlinefont variation to control outline roundness.Screen.Recording.2025-08-15.at.09.26.37.mov