CI: Show doctool diffs inside submodules#110243
Open
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Open
CI: Show doctool diffs inside submodules#110243aaronfranke wants to merge 1 commit intogodotengine:masterfrom
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Conversation
aaronfranke
force-pushed
the
show-submodule-diffs
branch
from
093ee87 to
5a616fd
Compare
aaronfranke
force-pushed
the
show-submodule-diffs
branch
from
5a616fd to
aa1e181
Compare
aaronfranke
force-pushed
the
show-submodule-diffs
branch
from
aa1e181 to
010a3ed
Compare
aaronfranke
force-pushed
the
show-submodule-diffs
branch
from
010a3ed to
a86e7b0
Compare
aaronfranke
force-pushed
the
show-submodule-diffs
branch
from
a86e7b0 to
83c770b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a similar vain to PR #89552, this does not directly alter the behavior for Godot itself, but it means that forks of Godot with submodules do not need to apply a patch to the CI scripts in order for the CI to build with the submodules. The Godot repo itself has no submodules, and therefore this does nothing, there are no downsides for us, but it benefits forks.
In master, doctool diffs in submodules show up like this:
Pretty useless, right? We have no clue what's actually wrong. With this PR, the diff shows up like this:
Disclaimer: ChatGPT suggested these arguments, I don't have a precise detailed understanding of them myself. But, hey, I've tested this and it works, and it appears straightforward, so I'm confident this is good.
This should be good to cherry-pick to past branches.