Fix Projection values being displayed transposed in the inspector#110526
Open
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Open
Fix Projection values being displayed transposed in the inspector#110526aaronfranke wants to merge 1 commit intogodotengine:masterfrom
aaronfranke wants to merge 1 commit intogodotengine:masterfrom
Conversation
aaronfranke
added
bug
topic:editor
cherrypick:4.3
Contributor
Member
Author
Member
|
Albeit very niche, this may affect the muscle memory of some users, that's worth keeping in mind. |
aaronfranke
force-pushed
the
fix-proj-insp-transpose
branch
from
792b618 to
e2ad428
Compare
aaronfranke
force-pushed
the
fix-proj-insp-transpose
branch
from
e2ad428 to
650b691
Compare
aaronfranke
force-pushed
the
fix-proj-insp-transpose
branch
from
650b691 to
fdc4e94
Compare
aaronfranke
force-pushed
the
fix-proj-insp-transpose
branch
from
fdc4e94 to
8e9464a
Compare
aaronfranke
force-pushed
the
fix-proj-insp-transpose
branch
from
8e9464a to
8261fa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Godot's internal C++ code, the
[]operator on Basis (3D) uses rows, but the[]operator on Projection uses columns. The inspector code in master was using the same numbers for Projection as it did for Basis, which resulted in the values being displayed as transposed. This PR fixes it by swapping the numbers, and I also threw in a change to preserve the unit just like it already does in Basis (3D) though this is different from Transform3D.In 3D, the Basis inspector works correctly, as shown in this video:
2025-09-14.23-41-47.mp4
The Projection inspector is transposed in master, as shown in this video of it affecting the wrong 4D basis vector:
2025-09-14.23-45-00.mp4
Simply put: the green-labeled values are supposed to move the green arrow, but the red arrow moved instead.
This PR fixes the issue, as shown in this video:
2025-09-14.23-42-29.mp4
This is purely a fix to the editor inspectors, there is no change to anywhere else.