-
-
Notifications
You must be signed in to change notification settings - Fork 23.7k
Add queue_update() to reflection probes
#112101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add queue_update() to reflection probes
#112101
Conversation
b557342 to
6e598de
Compare
ee9f236 to
eb076e7
Compare
|
@realbucketofchicken Please do your testing offline or on a branch that isn't submitted as a pull request, and push less frequently. Pushing so many times in a row creates lots pending of CI jobs. |
|
Ah i didnt know that, I will do my testing on a separate branch from now on. Thanks for telling me |
eb076e7 to
59fd81c
Compare
queue_update() to reflection probesqueue_update() to reflection probes
59fd81c to
ef08e4d
Compare
ef08e4d to
7591552
Compare
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally in all renderers, it works as expected. Code looks good to me.
Note that if you call queue_update() every frame, it will stop working after the reflection probe updates twice. However, this also occurs if you change the probe's rotation continuously (the previous workaround). This is also an issue on master, so this may have regressed recently (as I recall it working correctly before, i.e. the probe appears to update every ~12 rendered frames).
Testing project: test_pr_112101.zip
The project is capped at 60 FPS by default to ensure consistent update speeds across devices. Change this in the Project Settings if needed.
|
Could this be considered for 4.6? |
This PR implements a
queue_update()function to update a reflection probe without having to change its position.closes godotengine/godot-proposals#13466
This is the first time ive worked with godots source code so please excuse me if i forgot something.