Skip to content

Conversation

@akien-mga
Copy link
Member

@akien-mga akien-mga commented Oct 28, 2025

Various cherry-picks to fix MinGW-GCC 15 and Xcode 16 builds on CI.

Includes #112134 and a bunch of other cherry-picks which had not been included in 4.0 so far, but are necessary to compile with modern toolchains.

@akien-mga akien-mga added this to the 4.0 milestone Oct 28, 2025
@akien-mga akien-mga requested review from a team as code owners October 28, 2025 21:25
@akien-mga akien-mga marked this pull request as draft October 28, 2025 21:32
akien-mga and others added 2 commits October 28, 2025 22:34
This reverts commit 3d94d74.

The default changed and 15.3 is no longer available on GHA.
…s with newer MinGW SDKs.

(cherry picked from commit c363e13)
@akien-mga akien-mga force-pushed the 4.0-fix-gcc-warnings branch 7 times, most recently from 2491396 to e796286 Compare October 29, 2025 10:14
kisg and others added 8 commits October 29, 2025 12:12
Also fixes Vulkan build problem with recent Clang.

(cherry picked from commit 146ba41)
(cherry picked from commit 0baca62)
(cherry picked from commit 41268d7)
Upstreams the fix from godotengine#73310, so we can remove that patch.

The `OF` macro was also removed so I can drop the patch where I yell
at Gentoo developers.

(cherry picked from commit e0e1f2e)
Minizip includes previously backported fix for CVE-2023-45853,
and a Debian patch for CVE-2014-9485 was also upstreamed.

(cherry picked from commit 8ead8d2)
Should resolve issue godotengine#83342

(cherry picked from commits b97cb5e
and 21ae69a)
@akien-mga akien-mga force-pushed the 4.0-fix-gcc-warnings branch from e796286 to 6708cee Compare October 29, 2025 11:12
Repiteo and others added 2 commits October 29, 2025 13:08
(cherry picked from commit acdb866)

Adds some more fixes for 4.5.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
This was raised as a -Wmaybe-uninitialized warning by MinGW-GCC 15.2.1.
@akien-mga akien-mga force-pushed the 4.0-fix-gcc-warnings branch from 6708cee to 318a972 Compare October 29, 2025 12:09
@akien-mga akien-mga marked this pull request as ready for review October 29, 2025 12:13
@akien-mga akien-mga requested review from a team as code owners October 29, 2025 12:13
@akien-mga akien-mga changed the title [4.0] CI: Fix build with latest MinGW-GCC 15 [4.0] CI: Fix build with latest MinGW-GCC 15 and Xcode 16 Oct 29, 2025
@akien-mga akien-mga requested review from Ivorforce and Repiteo and removed request for a team October 29, 2025 13:58
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything came together on the CI side, so it should be good to go

@akien-mga akien-mga merged commit 83673ed into godotengine:4.0 Oct 30, 2025
17 checks passed
@akien-mga akien-mga deleted the 4.0-fix-gcc-warnings branch October 30, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants