Expose VideoStream playback instantiation and playback functions.#114515
Open
smix8 wants to merge 1 commit intogodotengine:masterfrom
Open
Expose VideoStream playback instantiation and playback functions.#114515smix8 wants to merge 1 commit intogodotengine:masterfrom
smix8 wants to merge 1 commit intogodotengine:masterfrom
Conversation
Expose VideoStream playback instantiation and playback functions to create and control video playback with scripting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
VideoStreamplayback instantiation and playback functions to create and control video playback with scripting.Registers the missing
VideoStreamPlaybackTheoraclass so it can be used with scripts.This is required for projects that make heavy use of many simultaneous running video files and need more precise control over playback loading and state (e.g. think of gui heavy games with lots of video animated interface parts).
Updates the existing documentation as it tells a sad story of being written in a not very clear state of mind as it ...
Currently the
VideoStreamhas a dysfunctional exposed setup to be controlled by scripting with the only other options being to go through a lot of node bloat and dummy objects turning things into an unnecessary performance hazard. The current expose setup does not really make sense. It looks like someone in the past exposed all the virtual override functions just for modules but then forgot to do the full work and also expose the actual functions or (sub) classes to make it fully workable. So if you want to avoid all those node and dummy object issues your only real options for effective video stream playbacks are to to use a C++ extension / module. Total overkill requirement considering that nothing here possibly called by scripting has any real performance impact from scripting, it is all just playback control.