Degrade logging errors from ClassDB in some cases#118081
Degrade logging errors from ClassDB in some cases#118081Ivorforce wants to merge 1 commit intogodotengine:masterfrom
ClassDB in some cases#118081Conversation
…fore `GDType`, and errors aren't technically needed.
|
ClassDB has more errors for missing classes: godot/core/object/class_db.cpp Line 848 in 137fa73 godot/core/object/class_db.cpp Line 2031 in 137fa73 godot/core/object/class_db.cpp Line 2039 in 137fa73 etc. I think logging an error makes sense. Like, if you want to get constant list from a class, you expect that it returns that list. If you make a typo in class name and the method fails silently, you may spend much time troubleshooting wrong problem. I'd change these errors to be consistent with the ones I linked above though. |
ClassDB/ClassInfotoGDType. #113586ClassDBtoGDType#117474As so often, I'm a bit over eager with printing on unexpected states.
This time, we get unexpected logs from autocompletion (#117914). While somewhat fishy to query
ClassDBwith classes that don't exist, it's not problematic and we didn't have logs before. So the agnostic thing would be to keep silently ignoring the invalid class name.We can discuss re-adding those logs in the future. But that would need to be a more sweeping change.