Skip to content

Android: Add missing set_restart_if_changed for haptic_on_long_press#118096

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
uno1982:mobile-haptic-editor-restart
Apr 2, 2026
Merged

Android: Add missing set_restart_if_changed for haptic_on_long_press#118096
Repiteo merged 1 commit intogodotengine:masterfrom
uno1982:mobile-haptic-editor-restart

Conversation

@uno1982
Copy link
Copy Markdown
Contributor

@uno1982 uno1982 commented Apr 1, 2026

The haptic_on_long_press editor setting was missing set_restart_if_changed, meaning toggling it in the UI would not take effect until the editor was manually restarted without any prompt to do so.

…setting

The haptic_on_long_press editor setting was missing set_restart_if_changed,
meaning toggling it in the UI would not take effect until the editor was
manually restarted without any prompt to do so.
@uno1982
Copy link
Copy Markdown
Contributor Author

uno1982 commented Apr 1, 2026

Feedback was given that the Galaxy M14 was throwing errors when trying to use the long press feature... Looking deeper it "could" be the Samsung overriding for non-system apps with view level suppression? I could try adding FLAG_IGNORE_VIEW_SETTING?? Would be good to have others here familar or I could apply the fix and have the OP of the issue test. @llama-nl

@uno1982
Copy link
Copy Markdown
Contributor Author

uno1982 commented Apr 1, 2026

Looking closely at the code the same pattern is used for the long press as right click ... there isn't any reason you would get the issue with haptic but not other settings.
GodotLib.getEditorSetting() — same as enable_long_press_as_right_click and enable_pan_and_scale_gestures
enable_long_press_as_right_click uses the exact same pattern

@uno1982
Copy link
Copy Markdown
Contributor Author

uno1982 commented Apr 1, 2026

This is the error reported .. putting here for easy ref
image

@syntaxerror247
Copy link
Copy Markdown
Member

@uno1982 issue with vibration not working on @llama-nl's device is a seperate issue, please create an issue for it to discuss it properly or you can discuss it at rocket chat https://chat.godotengine.org/channel/android

@syntaxerror247 syntaxerror247 modified the milestones: 4.x, 4.7 Apr 2, 2026
@Repiteo Repiteo merged commit 33536fb into godotengine:master Apr 2, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Apr 2, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants