Add hotkeys for positive and negative options in dialog box#118100
Open
Goldenlion5648 wants to merge 1 commit intogodotengine:masterfrom
Open
Add hotkeys for positive and negative options in dialog box#118100Goldenlion5648 wants to merge 1 commit intogodotengine:masterfrom
Goldenlion5648 wants to merge 1 commit intogodotengine:masterfrom
Conversation
62d9f42 to
0244dc9
Compare
Contributor
Author
|
With the above commit, the issue where pressing "y" even when typing the name for a file has been fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes godotengine/godot-proposals#13954 and fixes godotengine/godot-proposals#14559
This PR adds a hotkey to simulate pressing the positive option in a dialog (the
ok_button) and the negative option, like "discard". Not to be confused with the cancel button, which would just close the ui without doing anything.It seems even without this PR,
ui_close_dialogworks as the equivalent to pressing cancel, which @Calinou mentioned it didn't previously.In this video I am using the hotkeys, which work even when that is not the selected button.
screenrecording-2026-04-01_21-33-27.mp4