Fix incorrect line reporting for mixed indentation errors#118111
Open
vixxi77 wants to merge 1 commit intogodotengine:masterfrom
Open
Fix incorrect line reporting for mixed indentation errors#118111vixxi77 wants to merge 1 commit intogodotengine:masterfrom
vixxi77 wants to merge 1 commit intogodotengine:masterfrom
Conversation
dalexeev
reviewed
Apr 2, 2026
f988f8e to
a8e7125
Compare
dalexeev
reviewed
Apr 2, 2026
a8e7125 to
c6f9cb0
Compare
c6f9cb0 to
b9a0db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118004
Tokenizer did append correct error data to the token, but the parser ignored the errors location and only forwarded the error message. As a result the reported line would come from the parsers current location rather than the location of the actual error.
This change adds a push_error(const GDScriptTokenizer::Token &p_token) overload function, without touching the old API, allowing for the full use of the error tokens data.
Also tested:
Steps to reproduce
Screenshots
Before:

After:
