Remove redundant TOOLS_ENABLED ifdefs#118112
Open
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Open
Remove redundant TOOLS_ENABLED ifdefs#118112KoBeWi wants to merge 1 commit intogodotengine:masterfrom
KoBeWi wants to merge 1 commit intogodotengine:masterfrom
Conversation
Contributor
|
From https://github.com/KoBeWi/godot/blob/EDITORS_ENABLED/platform/android/SCsub#L35, it looks like those Android editor files are always compiled so we may want to keep the guards. |
Member
Author
|
Are they needed outside the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just had this on my TODO list. Seems like I already did #104130 once and forgot about it, but there are some new cases added apparently.
Not sure about the Android editor changes though. Looks like it was done for a reason?