Skip to content

Add fill rule optional argument to Geometry2D clipping functions#118171

Open
nerochiaro wants to merge 1 commit intogodotengine:masterfrom
nerochiaro:geometry2d_fill_rule
Open

Add fill rule optional argument to Geometry2D clipping functions#118171
nerochiaro wants to merge 1 commit intogodotengine:masterfrom
nerochiaro:geometry2d_fill_rule

Conversation

@nerochiaro
Copy link
Copy Markdown

@nerochiaro nerochiaro commented Apr 3, 2026

Closes godotengine/godot-proposals#5402

Allow specifying the fill rule for all the 4 polygon clipping operations and the 2 polyline clipping operations.

The fill rule argument is optional and defaults to "even-odd", which was the fixed value before the changes in this PR. As such, current code will continue to work exactly as before.

@nerochiaro nerochiaro marked this pull request as ready for review April 3, 2026 23:38
@nerochiaro nerochiaro requested review from a team as code owners April 3, 2026 23:38
@Nintorch Nintorch added this to the 4.x milestone Apr 4, 2026
@nerochiaro nerochiaro requested review from a team as code owners April 4, 2026 23:12
@nerochiaro
Copy link
Copy Markdown
Author

I updated the GDExtension compatibility files according to the instructions
This should fix the only check that I think was failing in CI. Not sure if all checks need to be re-run or just the failing one.

@nerochiaro nerochiaro force-pushed the geometry2d_fill_rule branch from b3515ce to 1c989c9 Compare April 4, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose FillRule in Geometry functions that use the Clipper library

2 participants