Adds ContextMenuSlot::CONTEXT_SLOT_INSPECTOR_PROPERTY to EditorContextMenuPlugin#118187
Open
SirLich wants to merge 1 commit intogodotengine:masterfrom
Open
Adds ContextMenuSlot::CONTEXT_SLOT_INSPECTOR_PROPERTY to EditorContextMenuPlugin#118187SirLich wants to merge 1 commit intogodotengine:masterfrom
SirLich wants to merge 1 commit intogodotengine:masterfrom
Conversation
SirLich
force-pushed
the
feature/context-slot-inspector-property
branch
from
c488d47 to
869473b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
EditorContextMenuPluginto be injected into the right-click menu of properties in the inspector. The argument topopup_menuwill be a string-name of the selected property (e.g.,visible), and the callback will provide you an editor property (e.g.,EditorPropertyBool), from which you can extract any information you need.Note: The inspector has three seperate popup menus, one each for: Properties, Sections, and Categories. This PR binds CONTEXT_SLOT_INSPECTOR_PROPERTY to properties only. I didn't view it as suitable to support Sections or Categories, because it makes the argument to
_popup_menuand the callback too dynamic (in one case, it's a property name, in another a section/category name).No AI was used in the creation of this PR.
Closes godotengine/godot-proposals#14608