[Web] Fix poll_export changing current export_preset#118190
Open
Hrothdel wants to merge 1 commit intogodotengine:masterfrom
Open
[Web] Fix poll_export changing current export_preset#118190Hrothdel wants to merge 1 commit intogodotengine:masterfrom
Hrothdel wants to merge 1 commit intogodotengine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115994
EditorExportPlatformWeb::poll_exportwas callingEditorExportPlatform::can_export, which iterates through the export plugins and ends up changing theirexport_presetfield to check for configuration warnings. These warnings were propagated topoll_export, but they were not used for anything.poll_exportgets called constantly, even while an export is ongoing, so theexport_presetmight change between calls toEditorExportPlugin::_export_beginandEditorExportPlugin::_export_end.This PR replaces the call to
can_exportwith the two calls inside it that actually report errors.It would be ideal to have the option to check for export plugin configuration warnings without changing its state, but that would probably take a more significant redesign.