feat(eval): EvalRunner trait, aikit RunOptions timeout/cwd, trace parity#112
Merged
feat(eval): EvalRunner trait, aikit RunOptions timeout/cwd, trace parity#112
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements eval execution through an
EvalRunnertrait withAikitEvalRunneras the default, keepsrun_eval_caseas a thin wrapper, and addsexecute_run_with_runnerfor injection.Uses
RunOptions::with_timeoutandwith_current_dirfrom aikit-sdk; persists the same event-derivedtrace.jsonlthat scoring uses. Structuralraw_jsoncounting formax_command_count. Integration test for trace persistence on disk.Documents
evals/ZIP exclusion in package CLI docs and onpackage_skill_with_idin core packaging.Bumps
Cargo.lockfor aikit-sdk.