Skip to content

feat(config/nacos): 变更回调增加变更前的配置对象，可以用来判断哪些配置变更进行特殊处理 #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppanphper wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −8
Open

feat(config/nacos): 变更回调增加变更前的配置对象，可以用来判断哪些配置变更进行特殊处理 #4331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3994b4f
nacos 变更回调增加变更前的配置对象，可以用来判断哪些配置变更进行特殊处理
ppanphper Jul 2, 2025
04a5478
adjust onConfigChange variable name
ppanphper Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions contrib/config/nacos/nacos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ import (

// Config is the configuration object for nacos client.
type Config struct {
ServerConfigs []constant.ServerConfig `v:"required"` // See constant.ServerConfig
ClientConfig constant.ClientConfig `v:"required"` // See constant.ClientConfig
ConfigParam vo.ConfigParam `v:"required"` // See vo.ConfigParam
Watch bool // Watch watches remote configuration updates, which updates local configuration in memory immediately when remote configuration changes.
OnConfigChange func(namespace, group, dataId, data string) // Configure change callback function
ServerConfigs []constant.ServerConfig `v:"required"` // See constant.ServerConfig
ClientConfig constant.ClientConfig `v:"required"` // See constant.ClientConfig
ConfigParam vo.ConfigParam `v:"required"` // See vo.ConfigParam
Watch bool // Watch watches remote configuration updates, which updates local configuration in memory immediately when remote configuration changes.
OnConfigChange func(beforeCfg *g.Var, namespace, group, dataId, data string) // Configure change callback function
}

// Client implements gcfg.Adapter implementing using nacos service.
Expand Down Expand Up @@ -127,9 +127,12 @@ func (c *Client) addWatcher() error {
return nil
}
c.config.ConfigParam.OnChange = func(namespace, group, dataId, data string) {
c.doUpdate(data)
if c.config.OnConfigChange != nil {
go c.config.OnConfigChange(namespace, group, dataId, data)
beforeCfg := g.NewVar(gjson.New(c.value.Val().(*gjson.Json).String()))
c.doUpdate(data)
go c.config.OnConfigChange(beforeCfg, namespace, group, dataId, data)
} else {
_ = c.doUpdate(data)
}
}

Expand Down
2 changes: 1 addition & 1 deletion contrib/config/nacos/nacos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TestNacosOnConfigChangeFunc(t *testing.T) {
ClientConfig: clientConfig,
ConfigParam: configParam,
Watch: true,
OnConfigChange: func(namespace, group, dataId, data string) {
OnConfigChange: func(beforeCfg *g.Var, namespace, group, dataId, data string) {
gtest.Assert("public", namespace)
gtest.Assert("test", group)
gtest.Assert("config.toml", dataId)
Expand Down
Loading