Skip to content

Conversation

@joy999
Copy link
Contributor

@joy999 joy999 commented Oct 25, 2025

add TPool[T] and let Pool base on it.

@joy999 joy999 added the feature label Oct 25, 2025
@joy999 joy999 requested a review from Copilot October 25, 2025 00:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a generic pool implementation TPool[T] to the gpool package and refactors the existing Pool type to use it as a foundation. The main purpose is to add type-safe generic pool functionality while maintaining backward compatibility with the existing Pool API.

Key Changes:

  • Added a new generic TPool[T] implementation with full pool functionality
  • Refactored Pool to wrap TPool[any] instead of maintaining duplicate implementation
  • Unified the codebase by eliminating code duplication between generic and non-generic pool types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
container/gpool/gpool_t.go Implements the new generic TPool[T] type with all pool operations (Get, Put, Clear, etc.) and expiration management
container/gpool/gpool.go Refactored to delegate all operations to the embedded TPool[any], converting Pool into a thin wrapper for backward compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants