Skip to content

Conversation

@dulanting
Copy link

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Optimize code using a more modern writing style.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: dulanting <dulanting@outlook.jp>
@dulanting dulanting requested a review from a team as a code owner October 28, 2025 07:53
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.84%. Comparing base (c8c11b4) to head (bbbb7af).
⚠️ Report is 583 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #22520       +/-   ##
===========================================
+ Coverage   45.36%   65.84%   +20.47%     
===========================================
  Files         244     1073      +829     
  Lines       13333   116106   +102773     
  Branches     2719     2931      +212     
===========================================
+ Hits         6049    76450    +70401     
- Misses       6983    35418    +28435     
- Partials      301     4238     +3937     
Flag Coverage Δ
unittests 65.84% <100.00%> (+20.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/secret/request.go 100.00% <100.00%> (ø)
src/lib/q/builder.go 92.46% <100.00%> (ø)
src/pkg/quota/dao/util.go 83.82% <100.00%> (ø)
src/server/middleware/util/util.go 92.85% <100.00%> (ø)

... and 983 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants