RFC: Fix a few pain points #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning the full error just adds extra noise to the error since it's already clear that there was an error with the number. This now says exactly what is wrong with the number.
A TypeError typically refers to the go type of something. This error is used to indicate that the value cannot be parsed correctly.
This was referenced Feb 25, 2022
ajmath
pushed a commit
to UrbanCompass/param
that referenced
this pull request
Feb 25, 2022
Merge upstream PR goji#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I fully expect this to be a bit controversial, but I'm introducing the issues to get some feedback.
go.mod: Not sure how goji as a whole is feeling about this one.
Using log.Fatal (pebkac) kills my entire server when hit. This affects all other requests. Of course, such errors should be caught in dev, but it's a bit presumptuous for a library.
This applies conventional error handling rather than panic()/recover().
For number errors, instead of returning the entire
strconv.NumError, only return the internal error. This simplifies errors fromparam: error parsing key "Thing" as int: strconv.ParseInt: parsing "4.2": invalid syntaxtoerror parsing key "Thing" as int: invalid syntax.Rename
TypeErrortoValueError. This might break some things, so I wanted some feedback here.