x/exp/shiny/driver/gldriver: allow ES2 on Linux and ES3 on Windows#19
Open
BenLubar wants to merge 1 commit intogolang:masterfrom
Open
x/exp/shiny/driver/gldriver: allow ES2 on Linux and ES3 on Windows#19BenLubar wants to merge 1 commit intogolang:masterfrom
BenLubar wants to merge 1 commit intogolang:masterfrom
Conversation
The previous check for GL_ES_2_0 was compile-time, which makes no sense. The lack of support for OpenGL ES 2.0 contexts on Linux also makes no sense as gldriver supports OpenGL ES 2.0 on other platforms.
Contributor
|
This PR (HEAD: 7efbff0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/exp/+/332449 to see it. Tip: You can toggle comments from me using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check for GL_ES_2_0 was compile-time, which makes no sense.
The lack of support for OpenGL ES 2.0 contexts on Linux also makes no
sense as gldriver supports OpenGL ES 2.0 on other platforms.