Skip to content

adjusting for better accessibility #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quanb-duy merged 1 commit into from
Mar 19, 2025
Merged

adjusting for better accessibility #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion assets/icons/GoodDataLearn.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/chevron-menu.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/icon-alert-default.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/icon-alert-info.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/icon-alert-label.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion assets/icons/icon-alert-warning.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 11 additions & 1 deletion assets/scss/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,14 @@
.panel-line:only-child {
display: none;
}
}
}

:focus {
outline: none;
}

:focus-visible {
outline: 2px solid Highlight; /* System highlight color (preferred) */
outline: 2px solid -webkit-focus-ring-color; /* Fallback for older browsers */
outline-offset: 2px;
}
2 changes: 1 addition & 1 deletion layouts/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,5 +97,5 @@
{{ $id := replace (lower .text) " " "-" }}
{{ $content := cond (isset . "icon") .icon .text }}

<a href="{{ $url }}" class="{{ .class }}" id="{{ .idPrefix }}{{ $id }}" target="_blank" {{ if (isset . "rel") }}rel="{{ .rel }}"{{ end }}>{{ $content }}</a>
<a href="{{ $url }}" class="{{ .class }}" id="{{ .idPrefix }}{{ $id }}" target="_blank" {{ if (isset . "rel") }}rel="{{ .rel }}"{{ end }} aria-label="{{ $id }}">{{ $content }}</a>
{{ end }}
2 changes: 1 addition & 1 deletion layouts/partials/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{{ $cover := .HasShortcode "blocks/cover" }}
<nav class="gd-docs-header-nav gd-docs-header-nav__first">
<div class="gd-docs-header-nav__left">
<a class="gd-docs-header-nav__logo gd-header-nav__logo" href="{{ .Site.Home.RelPermalink }}">
<a class="gd-docs-header-nav__logo gd-header-nav__logo" href="{{ .Site.Home.RelPermalink }}" aria-label="Go to documentation homepage">
{{ with resources.Get "icons/GoodDataLearn.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}
</a>
<span class="gd-header-nav__logo-text">Learn</span>
Expand Down
12 changes: 6 additions & 6 deletions layouts/partials/prev-next-pages.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
{{ else }}
{{ if $currentPage.NextInSection }}
{{ with $currentPage.NextInSection }}
<a href="{{ .RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__prev">
<span class="gd-docs-prev-next-pages__chevron">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
<a href="{{ .RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__prev" aria-label="Previous section: {{ .LinkTitle }}">
<span class="gd-docs-prev-next-pages__chevron" aria-hidden="true">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
{{ .LinkTitle }}
</a>
{{ end }}
Expand All @@ -33,16 +33,16 @@

{{ if $currentPage.IsSection }}
{{ with index $currentPage.Pages.ByWeight 0 }}
<a href="{{ .RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__next">
<span class="gd-docs-prev-next-pages__chevron">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
<a href="{{ .RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__next" aria-label="Next section: {{ .LinkTitle }}">
<span class="gd-docs-prev-next-pages__chevron" aria-hidden="true">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
{{ .LinkTitle }}
</a>
{{ end }}
{{ else }}
{{ if $currentPage.PrevInSection }}
{{ with $currentPage.PrevInSection }}
<a href="{{ $currentPage.PrevInSection.RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__next">
<span class="gd-docs-prev-next-pages__chevron">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
<a href="{{ $currentPage.PrevInSection.RelPermalink }}" class="gd-docs-prev-next-pages__link gd-docs-prev-next-pages__next" aria-label="Next section: {{ .LinkTitle }}">
<span class="gd-docs-prev-next-pages__chevron" aria-hidden="true">{{ with resources.Get "icons/chevron.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}</span>
{{ $currentPage.PrevInSection.LinkTitle }}
</a>
{{ end }}
Expand Down
4 changes: 2 additions & 2 deletions layouts/shortcodes/alert.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
{{ $_hugo_config := `{ "version": 1 }` }}
{{ $color := .Get "color" | default "primary" }}
{{ $icon := .Get "color" | default "default" }}
<div class="alert alert-{{ $color }}" role="alert">
<aside class="alert alert-{{ $color }}" role="alert" aria-labelledby="alert-title">
{{ with resources.Get (printf "icons/icon-alert-%s.svg" $icon) }}{{ ( . | minify).Content | safeHTML }}{{ end }}
{{ with .Get "title" }}<h4 class="alert-heading">{{ . | safeHTML }}</h4>{{ end }}
{{ if eq .Page.File.Ext "md" }}
{{ replaceRE "^<pre><code>" "" .Inner | safeHTML }}
{{ else }}
{{ .Inner | htmlUnescape | safeHTML }}
{{ end }}
</div>
</aside>